-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run e2e tests on arm #1965
Run e2e tests on arm #1965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change seems fine, but this will need a way to assert or ignore the arch in the expected output, see this failure:
ok 26 autosdk :: Run span :: link :: attributes
not ok 27 autosdk :: expected (redacted) trace output
# (from function `assert_equal' in file internal/test/e2e/autosdk/../../test_helpers/utilities.sh, line 192,
# in test file internal/test/e2e/autosdk/verify.bats, line 158)
# `assert_equal "$(git --no-pager diff ${BATS_TEST_DIRNAME}/traces.json)" ""' failed
#
# -- 💥 values are not equal 💥 --
# expected :
# actual : diff --git a/internal/test/e2e/autosdk/traces.json b/internal/test/e2e/autosdk/traces.json
# index 5361fa5..a5b2517 100644
# --- a/internal/test/e2e/autosdk/traces.json
# +++ b/internal/test/e2e/autosdk/traces.json
# @@ -6,7 +6,7 @@
# {
# "key": "process.runtime.description",
# "value": {
# - "stringValue": "go version 1.24.1 linux/amd64"
# + "stringValue": "go version 1.24.1 linux/arm64"
# }
# },
# {
If we want to redact this attribute from the bats tests to resolve this I'm in favor. This is also flaky already based on the Go version. It requires manual intervention when we update. |
All green ✅ |
No description provided.